Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: aledsage <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-268-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-268-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Adds
 JcloudsLocation.SKIP_JCLOUDS...
Content-Type: text/plain
Message-Id: <20141023225007.B8EF31FD3B@tyr.zones.apache.org>
Date: Thu, 23 Oct 2014 22:50:07 +0000 (UTC)

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/268#discussion_r19313633
  
    --- Diff: locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java ---
    @@ -1165,9 +1166,16 @@ protected LoginCredentials createUser(ComputeService computeService, NodeMetadat
                 if (initialPassword.isPresent()) sshProps.put("password", initialPassword.get());
                 if (initialPrivateKey.isPresent()) sshProps.put("privateKeyData", initialPrivateKey.get());
                 
    +            // TODO Retrying lots of times as workaround for vcloud-director. There the guest customizations
    +            // can cause the VM to reboot shortly after it was ssh'able.
                 Map<String,Object> execProps = Maps.newLinkedHashMap();
                 execProps.put(ShellTool.PROP_RUN_AS_ROOT.getName(), true);
    -            
    +            execProps.put(SshTool.PROP_SSH_TRIES.getName(), 50);
    +            execProps.put(SshTool.PROP_SSH_TRIES_TIMEOUT.getName(), 10*60*1000);
    --- End diff --
    
    Correct; it's overall. The 5 minutes mentioned in the PR description refers to `waitForReachable` which uses `WAIT_FOR_SSHABLE` - that defaults to 5m.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---