Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: aledsage <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-248-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-248-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Copy-state command fixes
Content-Type: text/plain
Message-Id: <20141017155604.17E1A939D6C@tyr.zones.apache.org>
Date: Fri, 17 Oct 2014 15:56:04 +0000 (UTC)

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/248#discussion_r19026035
  
    --- Diff: usage/launcher/src/main/java/brooklyn/launcher/BrooklynLauncher.java ---
    @@ -449,35 +453,96 @@ public BrooklynLauncher haHeartbeatPeriod(Duration val) {
             return this;
         }
     
    -    public BrooklynMementoRawData retrieveState() {
    -        initManagementContext();
    +    /**
    +     * @param destinationDir Directory for state to be copied to
    +     */
    +    public void copyPersistedState(String destinationDir) {
    +        copyPersistedState(destinationDir, null, null);
    +    }
     
    +    /**
    +     * @param destinationDir Directory for state to be copied to
    +     * @param destinationLocation Optional location if target for copied state is a blob store.
    +     */
    +    public void copyPersistedState(String destinationDir, @Nullable String destinationLocation) {
    +        copyPersistedState(destinationDir, destinationLocation, null);
    +    }
    +
    +    /**
    +     * @param destinationDir Directory for state to be copied to
    +     * @param destinationLocation Optional location if target for copied state is a blob store.
    +     * @param transformer Optional transformations to apply to retrieved state before it is copied.
    +     */
    +    public void copyPersistedState(String destinationDir, @Nullable String destinationLocation, @Nullable CompoundTransformer transformer) {
    +        initManagementContext();
             try {
    +            highAvailabilityMode = HighAvailabilityMode.HOT_STANDBY;
                 initPersistence();
             } catch (Exception e) {
                 handleSubsystemStartupError(ignorePersistenceErrors, "persistence", e);
             }
    +        ManagementPlaneSyncRecord planeState = managementContext.getHighAvailabilityManager().getManagementPlaneSyncState();
    +        BrooklynMementoRawData memento = retrieveState(false);
    +        BrooklynMementoRawData newMemento = memento;
    +        if (transformer != null) {
    +            try {
    +                newMemento = transformer.transform(memento);
    +            } catch (Exception e) {
    +                throw Throwables.propagate(e);
    --- End diff --
    
    Better to use `throw Exceptions.propagate(e)` so that it handles `InterruptedException` correctly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---