Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-233-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-233-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Some further tidies in wake
 of la...
Content-Type: text/plain
Message-Id: <20141016163610.3AA6F9C9FB1@tyr.zones.apache.org>
Date: Thu, 16 Oct 2014 16:36:10 +0000 (UTC)

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/233#discussion_r18968148
  
    --- Diff: core/src/main/java/brooklyn/location/basic/BasicLocationRegistry.java ---
    @@ -190,52 +194,58 @@ void disablePersistence() {
             // defining the format and file etc)
         }
     
    -    BasicLocationDefinition localhost(String id) {
    +    static BasicLocationDefinition localhost(String id) {
    --- End diff --
    
    sure `protected` is fine


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---