Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: grkvlt <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-225-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-225-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Miscellaneous 20141007
Content-Type: text/plain
Message-Id: <20141010145957.C3C123D5F9@tyr.zones.apache.org>
Date: Fri, 10 Oct 2014 14:59:57 +0000 (UTC)

Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/225#discussion_r18710801
  
    --- Diff: usage/dist/src/main/dist/bin/item-lister ---
    @@ -0,0 +1,42 @@
    +#!/bin/bash
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#  http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +
    +#set -x # debug
    +
    +ROOT=$(cd "$(dirname "$0")/.." && pwd -P)
    +
    +# discover BROOKLYN_HOME if not set, by attempting to resolve absolute path of this command
    +if [ -z "$BROOKLYN_HOME" ] ; then
    +    BROOKLYN_HOME=$(cd "$(dirname "$(readlink -f "$0" 2> /dev/null || readlink "$0" 2> /dev/null || echo "$0")")/.." && pwd)
    +fi
    +
    +# use default memory settings, if not specified
    +if [ -z "${JAVA_OPTS}" ] ; then
    +    JAVA_OPTS="-Xms256m -Xmx1g -XX:MaxPermSize=256m"
    +fi
    +
    +# set up the classpath
    +INITIAL_CLASSPATH=${BROOKLYN_HOME}/conf:${BROOKLYN_HOME}/lib/patch/*:${BROOKLYN_HOME}/lib/brooklyn/*:${BROOKLYN_HOME}/lib/dropins/*
    +# specify additional CP args in BROOKLYN_CLASSPATH
    +if [ ! -z "${BROOKLYN_CLASSPATH}" ]; then
    +    INITIAL_CLASSPATH=${BROOKLYN_CLASSPATH}:${INITIAL_CLASSPATH}
    +fi
    +
    +# run item-lister
    +exec java ${JAVA_OPTS} -cp "${INITIAL_CLASSPATH}" brooklyn.cli.itemlister.ItemLister "$@"
    --- End diff --
    
    Now the `brooklyn` script subsumes both the item lister and cloud explorer, which I think is much nicer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---