Return-Path: X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 137A517626 for ; Wed, 1 Oct 2014 02:29:27 +0000 (UTC) Received: (qmail 36805 invoked by uid 500); 1 Oct 2014 02:29:27 -0000 Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org Received: (qmail 36771 invoked by uid 500); 1 Oct 2014 02:29:27 -0000 Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.incubator.apache.org Delivered-To: mailing list dev@brooklyn.incubator.apache.org Received: (qmail 36760 invoked by uid 99); 1 Oct 2014 02:29:26 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Oct 2014 02:29:26 +0000 X-ASF-Spam-Status: No, hits=-2000.6 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 01 Oct 2014 02:29:25 +0000 Received: (qmail 34691 invoked by uid 99); 1 Oct 2014 02:29:04 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Oct 2014 02:29:04 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 938EAA1D710; Wed, 1 Oct 2014 02:29:03 +0000 (UTC) From: ahgittin To: dev@brooklyn.incubator.apache.org Reply-To: dev@brooklyn.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-brooklyn pull request: [WIP] Rebind read only Content-Type: text/plain Message-Id: <20141001022903.938EAA1D710@tyr.zones.apache.org> Date: Wed, 1 Oct 2014 02:29:03 +0000 (UTC) X-Virus-Checked: Checked by ClamAV on apache.org Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/197#issuecomment-57411401 @aledsage thanks for your review comments, i'm rather happier with the design now, been able to simplify it a bit more. it is still using the actual entity, which feels right to me, with fairly simple code -- at least it's a fraction of the complexity of the existing rebind code, and there aren't too many code smells. wdyt? `HotStandbyTest` is the place to start, testing a lot of things Need to do a bit more around feeds etc, and open up an API for using this ... and then i think it's done, so review away at the guts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---