brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] incubator-brooklyn pull request: Fix various integration tests
Date Fri, 31 Oct 2014 10:58:52 GMT
GitHub user aledsage opened a pull request:

    Fix various integration tests

    See detailed description in each individual commit for more info.

You can merge this pull request into a Git repository by running:

    $ git pull fix/various-integrationtests-20141031

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #285
commit 2fa654437cdb7850ccd3ce581fbd9a111da2e5cb
Author: Aled Sage <>
Date:   2014-10-31T09:10:55Z

    Fix JavaWebAppWithDslYamlRebindIntegrationTest
    - support serialising/deserializing JavaBrooklynClassLoadingContext
      for “common case” of constructing with ManagementContext and no
      custom ClassLoader.

commit ba42c5469112b38e957640dfd9e0746a2eedb754
Author: Aled Sage <>
Date:   2014-10-31T09:41:56Z

    Fixing EntityConfigResource ClassCastException
    - BrooklynJacksonSerializerTest failed with ClassCastException in
    - Unclear why it was in that code at all; have added explicit test 
      for “Accepts: text/plain”

commit 6f6b8dd9b2a99e8630805c04809db0a231ff8edb
Author: Aled Sage <>
Date:   2014-10-31T10:17:41Z

    Fix NodeJsWebAppSimpleIntegrationTest
    - Ensure check port availability early, so get nice error message 
      for it.
      TODO other entities should probably follow same pattern?!
    - copyInstallResources: don’t use env for create-install-dir,
      in case sub-class is setting lots of things or that would
      cause a config value of type attributeWhenReady to be resolved
    - Code tidy: Networking.checkPortsValid

commit 76301ec9578983b420d7349deff8634e1c56a668
Author: Aled Sage <>
Date:   2014-10-31T10:43:05Z

    Fix MongoDBReplicaSetIntegrationTest
    - need to retry addMember/removeMember if first attempt failed
      (e.g. because primary was not yet stable, or attributes of
      primary were temporarily out-of-sync)
    - code tidy of MongoDBReplicaSetIntegrationTest

commit 6213ddaac33295b870e381cd173d22e6672bdd6f
Author: Aled Sage <>
Date:   2014-10-31T10:56:03Z

    Fix NginxClusterIntegrationTest


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message