brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <>
Subject [GitHub] incubator-brooklyn pull request: Fix various integration tests
Date Fri, 31 Oct 2014 14:03:25 GMT
Github user grkvlt commented on a diff in the pull request:
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/mongodb/
    @@ -224,17 +224,28 @@ public void run() {
                     // SERVICE_UP is not guaranteed when additional members are added to
the set.
                     Boolean isAvailable = secondary.getAttribute(MongoDBServer.SERVICE_UP);
                     MongoDBServer primary = getPrimary();
    +                boolean reschedule;
                     if (Boolean.TRUE.equals(isAvailable) && primary != null) {
    -                    primary.addMemberToReplicaSet(secondary, nextMemberId.incrementAndGet());
    -                    if (LOG.isInfoEnabled()) {
    --- End diff --
    Yes, I don't think we _ever_ need this check, only for `DEBUG` and `TRACE` logging should
there be a check.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message