brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix various integration tests
Date Fri, 31 Oct 2014 13:55:04 GMT
Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/285#discussion_r19667468
  
    --- Diff: core/src/main/java/brooklyn/management/classloading/JavaBrooklynClassLoadingContext.java
---
    @@ -18,34 +18,56 @@
      */
     package brooklyn.management.classloading;
     
    -import java.net.URL;
    +import static com.google.common.base.Preconditions.checkNotNull;
    +import static com.google.common.base.Preconditions.checkState;
     
    -import com.google.common.base.Objects;
    +import java.net.URL;
     
     import brooklyn.management.ManagementContext;
     import brooklyn.util.exceptions.Exceptions;
     import brooklyn.util.guava.Maybe;
     
    +import com.google.common.base.Objects;
    +
     public class JavaBrooklynClassLoadingContext extends AbstractBrooklynClassLoadingContext
{
    --- End diff --
    
    FYI, confusing name - how could it be anything other that a _Java_ classloader context?
Of course the other type is _Osgi_ which makes sense, but a bit of Javadoc on these classes
would help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message