brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alasdairhodge <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix various integration tests
Date Fri, 31 Oct 2014 13:36:13 GMT
Github user alasdairhodge commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/285#discussion_r19666549
  
    --- Diff: software/webapp/src/main/java/brooklyn/entity/webapp/nodejs/NodeJsWebAppSshDriver.java
---
    @@ -85,6 +85,12 @@ public void postLaunch() {
         }
     
         @Override
    +    public void preInstall() {
    +        super.preInstall();
    +        Networking.checkPortsValid(getPortMap());
    --- End diff --
    
    Agree that this feels like it affects more than just the node.js entity. Maybe add a TODO
to suggest a future refactoring.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message