brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alasdairhodge <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix various integration tests
Date Fri, 31 Oct 2014 06:51:06 GMT
Github user alasdairhodge commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/281#discussion_r19654028
  
    --- Diff: usage/launcher/src/test/java/brooklyn/launcher/BrooklynLauncherRebindToCloudObjectStoreTest.java
---
    @@ -91,53 +91,56 @@ protected void checkPersistenceContainerNameIsDefault() {
             checkPersistenceContainerNameIs(BrooklynServerConfig.DEFAULT_PERSISTENCE_CONTAINER_NAME);
         }
     
    -    @Override @Test(groups="Integration")
    +    @Override @Test(groups="Live")
         public void testRebindsToExistingApp() throws Exception {
             super.testRebindsToExistingApp();
         }
     
    -    @Override @Test(groups="Integration")
    +    @Override @Test(groups="Live")
         public void testRebindCanAddNewApps() throws Exception {
             super.testRebindCanAddNewApps();
         }
     
    -    @Override @Test(groups="Integration")
    +    @Override @Test(groups="Live")
         public void testAutoRebindsToExistingApp() throws Exception {
             super.testAutoRebindsToExistingApp();
         }
     
    -    @Override @Test(groups="Integration")
    +    // TODO Marked as work-in-progress because "clean" does not backup and then clean
out the existing
    +    // object store's bucket. Unclear what best behaviour there should be: should we
really delete
    +    // the data?! We better be confident about our backup!
    --- End diff --
    
    Getting off on a tangent here (particularly as the PR is now merged!) but arguably it
isn't Brooklyn's job to create the backup; I don't have that expectation when I run `mvn clean`
or `make clean`, for example.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message