brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: HA info in the docs on persistenc...
Date Thu, 30 Oct 2014 22:49:16 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/282#discussion_r19641981
  
    --- Diff: usage/cli/src/main/java/brooklyn/cli/Main.java ---
    @@ -321,11 +321,11 @@ private String readLine(InputStream in) throws IOException {
                     title = "high availability mode",
                     description =
                             "The high availability mode. Possible values are: \n"+
    -                        "disabled: management node works in isolation - will not cooperate
with any other standby/master nodes in management plane; \n"+
    +                        "disabled: management node works in isolation; it will not cooperate
with any other standby/master nodes in management plane; \n"+
    --- End diff --
    
    Unfortunately (last I looked) `io.airlift.command.Cli` strips out the `\n` chars when
showing the description. Therefore I prefer `-` as separator rather than semicolon. Without
the `\n`, it's hard to tell that the `;` before the next term is different from the semicolon
in the middle of the description.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message