brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Logging brooklyn-persister thread...
Date Thu, 30 Oct 2014 22:07:05 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/283#discussion_r19639783
  
    --- Diff: usage/logback-includes/src/main/java/brooklyn/logging/JcloudsPersistenceThreadDiscriminator.java
---
    @@ -0,0 +1,65 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package brooklyn.logging;
    +
    +import ch.qos.logback.classic.spi.ILoggingEvent;
    +import ch.qos.logback.core.sift.Discriminator;
    +
    +/**
    + * Discriminates logging events per whether the current thread is named "brooklyn-persister"
or not.
    + * <p>
    + * Use a {@link ch.qos.logback.classic.sift.SiftingAppender SiftingAppender} and refer
to the
    + * <code>jcloudsPersistSwitch</code> property. The property's value will
be either "jclouds-persister",
    + * for messages logged from the persistence thread, and "jclouds" otherwise.
    + */
    +public class JcloudsPersistenceThreadDiscriminator implements Discriminator<ILoggingEvent>
{
    +
    +    private static final String PERSISTENCE_THREAD = "brooklyn-persister";
    +    private static final String KEY = "jcloudsPersistSwitch";
    +
    +    private boolean isStarted;
    +
    +    @Override
    +    public String getDiscriminatingValue(ILoggingEvent o) {
    +        return Thread.currentThread().getName().equals(PERSISTENCE_THREAD)
    --- End diff --
    
    Do we want `startsWith` rather than `equals`? If there is already a thread with that name,
then `return new Thread(r, "brooklyn-persister")` will use the thread name with a number suffix.
That would be the case for running tests with multiple management contexts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message