brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alasdairhodge <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix various integration tests
Date Thu, 30 Oct 2014 18:23:00 GMT
Github user alasdairhodge commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/281#discussion_r19625483
  
    --- Diff: software/base/src/test/java/brooklyn/entity/software/mysql/DynamicToyMySqlEntityBuilder.java
---
    @@ -149,10 +149,19 @@ protected void postStartCustom() {
                     // and set the PID
                     entity().setAttribute(Attributes.PID, 
                             Integer.parseInt(DynamicTasks.queue(SshEffectorTasks.ssh("cat
"+dir(entity)+"/*/data/*.pid")).block().getStdout().trim()));
    +                
    +                // TODO Without this, tests fail because nothing else sets serviceUp!
    +                // Really should set this with a Feed that checks pid periodically.
    +                // Should this instead be using SERVICE_NOT_UP_INDICATORS?
    +                entity().setAttribute(Attributes.SERVICE_UP, true);
    --- End diff --
    
    Aside: what's the purpose of the ToyEntityBuilder?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message