brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix: various 20141028
Date Wed, 29 Oct 2014 15:58:00 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/280#discussion_r19548357
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/elasticsearch/ElasticSearchNodeSshDriver.java
---
    @@ -54,7 +54,7 @@ public void install() {
             String saveAs = resolver.getFilename();
             
             List<String> commands = ImmutableList.<String>builder()
    -            .add(BashCommands.installJavaLatestOrFail())
    +            .add(BashCommands.installJavaLatestOrWarn())
    --- End diff --
    
    On OS X, it doesn't automatically install Java so fails. But Java was already installed.
    When I changed to `OrWarn` then I could then run the `ElasticSearchNodeSshDriver` integration
tests on OS X.
    
    Arguably we should do a better job of checking if Java is already installed!
    Currently our `BashCommands.installJava(int version)` doesn't check the current version
at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message