brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alasdairhodge <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix: various 20141028
Date Wed, 29 Oct 2014 14:38:34 GMT
Github user alasdairhodge commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/280#discussion_r19541508
  
    --- Diff: software/nosql/src/test/java/brooklyn/entity/nosql/elasticsearch/ElasticSearchClusterIntegrationTest.java
---
    @@ -103,9 +109,20 @@ public void testPutAndGet() throws URISyntaxException {
                         new HttpGet(getBaseUri + "/mydocuments/docs/1/_source"));
                 assertEquals(getResponse.getResponseCode(), 200);
                 assertEquals(HttpValueFunctions.jsonContents("foo", String.class).apply(getResponse),
"bar");
    -            
    -            totalDocumentCount += node.getAttribute(ElasticSearchNode.DOCUMENT_COUNT);
             }
    -        assertEquals(totalDocumentCount, 1);
    +        Asserts.succeedsEventually(new Runnable() {
    +            public void run() {
    +                int count = clusterDocumentCount();
    +                assertTrue(count >= 1, "count="+count);
    +                LOG.info("Document count is "+count);
    --- End diff --
    
    `debug` instead of `info`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message