brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fixes for Riak under Clocker
Date Tue, 28 Oct 2014 14:38:05 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/276#discussion_r19474301
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/riak/RiakNodeSshDriver.java
---
    @@ -192,14 +195,14 @@ public void customize() {
             customizeScript.execute();
     
             //set the riak node name
    -        entity.setAttribute(RiakNode.RIAK_NODE_NAME, format("riak@%s", getHostname()));
    +        entity.setAttribute(RiakNode.RIAK_NODE_NAME, format("riak@%s", getEntity().getAttribute(Attributes.SUBNET_HOSTNAME)));
    --- End diff --
    
    is `SUBNET_HOSTNAME` always guaranteed to be populated?  suggest calling `getSubnetHostname()`
and putting logic there to fallback to using `getHostname()` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message