brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] incubator-brooklyn pull request: Brooklyn node and cluster upgrade
Date Mon, 27 Oct 2014 17:29:46 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: software/base/src/main/java/brooklyn/entity/brooklynnode/
    @@ -213,6 +227,11 @@ private static String toNullableString(Object obj) {
    +    @Override
    +    protected void preStart() {
    --- End diff --
    I'd order the methods so that `preStart()` comes before `preStop()`. My rule of thumb
is to order them as one might think about the lifecycle (e.g. for a driver then install, customize,
launch, isRunning, stop, kill).

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message