brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Brooklyn node and cluster upgrade
Date Mon, 27 Oct 2014 14:46:50 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/272#discussion_r19409028
  
    --- Diff: api/src/main/java/brooklyn/entity/proxying/EntitySpec.java ---
    @@ -229,6 +230,12 @@ public Entity getParent() {
         public Map<ConfigKey<?>, Object> getConfig() {
             return Collections.unmodifiableMap(config);
         }
    +    
    +    /** @return Live instance of the config map, for instance in case mass clearances
are desired */
    +    @Beta
    +    public Map<ConfigKey<?>, Object> getConfigLive() {
    --- End diff --
    
    I don't like exposing the underlying state; I'd prefer we had a `clearConfig()` method
if that is the use-case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message