brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From richardcloudsoft <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: half a dozen misc minor improveme...
Date Mon, 27 Oct 2014 10:42:39 GMT
Github user richardcloudsoft commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/273#issuecomment-60574767
  
    Looks good in principle, a couple of minor comments. Could you confirm if the build failure
is related or if it is a transient failure?
    
    A nit-picky point, but could I ask you to use the Git-standard commit message format as
described at [1](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html), particularly
the first line rule? GitHub assumes that rule and as a result the long lines you use are formatted
in a difficult-to-read way. Thanks :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message