brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: allow parameters for restart effe...
Date Mon, 27 Oct 2014 07:33:10 GMT
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/260#issuecomment-60557950
  
    i've changed the text and some naming around `RestartMode.AUTO` -- thanks @rdowner.  
    
    using `preStop()` or `postStop()` instead of `doStop()` was done on a case-by-case basis.
 we need to move away from overriding the `doXxx()` methods because they won't have the parameters
passed in.  it would be nice to be fully backwards compatible but this would make for ugliness
i think (e.g. a `ThreadLocal parameters()` method?), so the better resolution i thought was
to make it so incompatible usages are easily-discovered-and-fixed compilation errors.
    
    
    addressed all the other comments, i think.  i look forward to your re-review @rdowner
!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message