brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rdowner <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: allow parameters for restart effe...
Date Fri, 24 Oct 2014 15:55:53 GMT
Github user rdowner commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/260#discussion_r19347153
  
    --- Diff: software/base/src/main/java/brooklyn/entity/basic/SoftwareProcessImpl.java ---
    @@ -471,24 +483,39 @@ public final void restart() {
         /**
          * To be overridden instead of {@link #start(Collection)}; sub-classes should call
{@code super.doStart(locations)} and should
          * add do additional work via tasks, executed using {@link DynamicTasks#queue(String,
Callable)}.
    +     * @deprecated since 0.7.0 override {@link #preStart()} or {@link #postStart()},
or define custom lifecycle tasks if needed
    +     * (this method is no longer invoked, hence now marking it final)
          */
    -    protected void doStart(Collection<? extends Location> locations) {
    +    @Deprecated
    +    protected final void doStart(Collection<? extends Location> locations) {
             LIFECYCLE_TASKS.start(locations);
         }
         
         /**
          * To be overridden instead of {@link #stop()}; sub-classes should call {@code super.doStop()}
and should
          * add do additional work via tasks, executed using {@link DynamicTasks#queue(String,
Callable)}.
    +     * @deprecated since 0.7.0 override {@link #preStop()} or {@link #postStop()}, or
define custom lifecycle tasks if needed
    +     * (this method is no longer invoked, hence now marking it final)
          */
    -    protected void doStop() {
    +    @Deprecated
    +    protected final void doStop() {
             LIFECYCLE_TASKS.stop();
         }
         
         /**
    -     * To be overridden instead of {@link #restart()}; sub-classes should call {@code
super.doRestart()} and should
    +     * To be overridden instead of {@link #restart()}; sub-classes should call {@code
super.doRestart(ConfigBag)} and should
          * add do additional work via tasks, executed using {@link DynamicTasks#queue(String,
Callable)}.
    +     * @deprecated since 0.7.0 define custom lifecycle tasks if needed
    +     * (this method is no longer invoked, hence now marking it final)
          */
    --- End diff --
    
    Oh hang on, I may have mis-read the diff. Give me another minute.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message