brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: DNS entity improvements
Date Thu, 23 Oct 2014 20:18:46 GMT
Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/263#discussion_r19304525
  
    --- Diff: software/network/src/main/java/brooklyn/entity/network/bind/BindDnsServerImpl.java
---
    @@ -18,57 +18,62 @@
      */
     package brooklyn.entity.network.bind;
     
    +import static com.google.common.base.Preconditions.checkNotNull;
    +
     import java.io.ByteArrayInputStream;
    +import java.io.StringReader;
    +import java.util.Collection;
     import java.util.Map;
    -import java.util.concurrent.ConcurrentMap;
     import java.util.concurrent.atomic.AtomicLong;
     
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     
    +import com.google.common.base.Joiner;
    +import com.google.common.base.Predicate;
    +import com.google.common.base.Splitter;
    +import com.google.common.collect.BiMap;
    +import com.google.common.collect.FluentIterable;
    +import com.google.common.collect.HashBiMap;
    +import com.google.common.collect.ImmutableList;
    +import com.google.common.collect.ImmutableListMultimap;
    +import com.google.common.collect.ImmutableMap;
    +import com.google.common.collect.ImmutableMultimap;
    +import com.google.common.collect.ImmutableSet;
    +import com.google.common.collect.Iterables;
    +import com.google.common.collect.Lists;
    +import com.google.common.collect.Maps;
    +import com.google.common.collect.Multimap;
    +import com.google.common.collect.MultimapBuilder;
    +import com.google.common.collect.Multimaps;
    +
     import brooklyn.entity.Entity;
    +import brooklyn.entity.basic.Attributes;
     import brooklyn.entity.basic.DynamicGroup;
    +import brooklyn.entity.basic.EntityFunctions;
    +import brooklyn.entity.basic.Lifecycle;
     import brooklyn.entity.basic.SoftwareProcessImpl;
     import brooklyn.entity.group.AbstractMembershipTrackingPolicy;
     import brooklyn.entity.proxying.EntitySpec;
    -import brooklyn.entity.trait.Startable;
    -import brooklyn.location.Location;
    -import brooklyn.location.MachineLocation;
    +import brooklyn.location.basic.Machines;
     import brooklyn.location.basic.SshMachineLocation;
     import brooklyn.policy.PolicySpec;
    -import brooklyn.util.collections.MutableMap;
    +import brooklyn.util.guava.Maybe;
     import brooklyn.util.net.Cidr;
     import brooklyn.util.ssh.BashCommands;
     import brooklyn.util.text.Strings;
     
    -import com.google.common.base.Joiner;
    -import com.google.common.base.Optional;
    -import com.google.common.base.Predicates;
    -import com.google.common.base.Splitter;
    -import com.google.common.collect.HashMultimap;
    -import com.google.common.collect.ImmutableList;
    -import com.google.common.collect.ImmutableSet;
    -import com.google.common.collect.Iterables;
    -import com.google.common.collect.Lists;
    -import com.google.common.collect.Maps;
    -import com.google.common.collect.Multimap;
    -
     /**
      * This sets up a BIND DNS server.
      * <p>
    - * <b>NOTE</b> This entity has only been certified on <i>CentOS</i>
and <i>RHEL</i> operating systems.
    + * <b>NOTE</b> This entity has only been certified on <i>CentOS</i>,
<i>RHEL</i>,
    + * <i>Ubuntu</i> and <i>Debian</i> operating systems.
      */
     public class BindDnsServerImpl extends SoftwareProcessImpl implements BindDnsServer {
     
         private static final Logger LOG = LoggerFactory.getLogger(BindDnsServerImpl.class);
     
         private AtomicLong serial = new AtomicLong(System.currentTimeMillis());
    --- End diff --
    
    Could this go in an attribute, too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message