brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Rename brooklynObject.getTagSuppo...
Date Mon, 20 Oct 2014 23:30:51 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/258#discussion_r19121491
  
    --- Diff: api/src/main/java/brooklyn/basic/BrooklynObject.java ---
    @@ -41,7 +41,7 @@
          * They must not be null (as {@link ImmutableMap} may be used under the covers; also
there is little point!);
          * and they should be amenable to our persistence (on-disk serialization) and our
JSON serialization in the REST API.
          */
    -    TagSupport getTagSupport();
    --- End diff --
    
    and why do this for `TagSupport` but not the other `XxxxSupport` ?  feels like we should
be consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message