brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Bunch of fixes observed during ho...
Date Sat, 18 Oct 2014 12:50:29 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/255#discussion_r19053486
  
    --- Diff: core/src/main/java/brooklyn/entity/rebind/BasicEntityRebindSupport.java ---
    @@ -156,31 +159,27 @@ public void addFeeds(RebindContext rebindContext, EntityMemento
memento) {
                     } catch (Exception e) {
                         rebindContext.getExceptionHandler().onAddFeedFailed(entity, feed,
e);
                     }
    -            } else {
    -                LOG.warn("Feed not found; discarding feed {} of entity {}({})",
    -                        new Object[] {feedId, memento.getType(), memento.getId()});
    -            }
    -            
    -            if (feed != null) {
    +                
                     try {
    +                    // XXX
    --- End diff --
    
    fixed with the real comment, thx


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message