brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Tasks stop on unmanaged
Date Fri, 17 Oct 2014 08:59:49 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/252#discussion_r19007830
  
    --- Diff: core/src/test/java/brooklyn/entity/group/DynamicFabricTest.java ---
    @@ -226,7 +226,7 @@ public void testDynamicFabricStartsEntitiesInParallel() throws Exception
{
                             @Override public Boolean call() {
                                 return latches.size() == locs.size();
                             }})
    -                .run();
    +                .runRequiringTrue();
    --- End diff --
    
    This particular instance I just fixed the `runRequiringTrue` bit but elsewhere I added
some `Repeater` calls.  It's just such a nice API :) but agree `Asserts.eventually` is more
appropriate and allows external control of timings.
    
    (One minor point, if I'm *debugging* tests, it's nice to have control of timings, so perhaps
a `Asserts.DEFAULT_EVENTUALLY_TIMEOUT` field would help.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message