brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Copy-state command fixes
Date Wed, 15 Oct 2014 22:13:18 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/248#discussion_r18926961
  
    --- Diff: core/src/main/java/brooklyn/management/ha/ManagementPlaneSyncRecordPersisterToObjectStore.java
---
    @@ -291,6 +291,15 @@ public void waitForWritesCompleted(Duration timeout) throws InterruptedException
             masterWriter.waitForCurrentWrites(timeout);
         }
     
    +    public void checkpoint(ManagementPlaneSyncRecord record) {
    +        init();
    +        for (ManagementNodeSyncRecord node : record.getManagementNodes().values()) {
    +            if (node.getNodeId() != null) {
    --- End diff --
    
    Null check included in case the node in the memento is the one being initialised by `BrooklynLauncher`
in the copy state command (whose state is `INITIALIZING` and whose id is `null`). Is there
a better way to handle this case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message