brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Dns entity
Date Wed, 15 Oct 2014 12:26:21 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/243#discussion_r18889861
  
    --- Diff: usage/jsgui/src/main/webapp/assets/js/util/brooklyn-utils.js ---
    @@ -140,15 +140,19 @@ define([
          * alternate message if parsing fails or the parsed object has no message.
          * @param {jqXHR} xhrResponse
          * @param {string} alternateMessage
    -     * @param {string} logMessage, if false or null, does not log; 
    -     *   otherwise it logs a message and the xhrResponse, with logMessage (or with alternateMessage
if logMessage is true)
    +     * @param {string=} logMessage if false or null, does not log;
    --- End diff --
    
    @sjcorbett has confirmed that the `=` indicates it is an optional argument. So this is
deliberate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message