brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix OSGi integration tests
Date Tue, 14 Oct 2014 11:34:28 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/242#discussion_r18822216
  
    --- Diff: core/src/test/java/brooklyn/management/osgi/OsgiStandaloneTest.java ---
    @@ -117,11 +117,15 @@ public void testBootBundle() throws Exception {
             Assert.assertEquals(Entity.class, bundleCls.getClassLoader().loadClass(Entity.class.getName()));
         }
     
    -    // Marked as integration because jenkins configures an unusual local .m2 repository
location,
    -    // so attempts to look up the local artifact fail.
    -    @Test(groups="Integration")
    +    @Test
         public void testDuplicateBundle() throws Exception {
    -        helperDuplicateBundle(MavenRetriever.localUrl(new MavenArtifact("org.apache.brooklyn",
"brooklyn-api", "jar", "0.7.0-SNAPSHOT")));
    +        MavenArtifact artifact = new MavenArtifact("org.apache.brooklyn", "brooklyn-api",
"jar", "0.7.0-SNAPSHOT");
    +        String localUrl = MavenRetriever.localUrl(artifact);
    +        if ("file".equals(Urls.getProtocol(localUrl))) {
    +            helperDuplicateBundle(localUrl);
    +        } else {
    +            log.warn("Skipping test OsgiStandaloneTest.testDuplicateBundle due to " +
artifact + " not available in local repo.");
    --- End diff --
    
    testRemoteDuplicateBundle already tests this scenario, no point in testing with remote
URL.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message