brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Change references to org.apache.b...
Date Mon, 13 Oct 2014 16:13:51 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/237#discussion_r18778373
  
    --- Diff: software/base/src/test/java/brooklyn/entity/brooklynnode/BrooklynNodeTest.java
---
    @@ -58,8 +58,8 @@ public void tearDown() throws Exception {
         
         @Test
         public void testGeneratesCorrectSnapshotDownload() throws Exception {
    -        String version = "0.6.0-SNAPSHOT";
    -        String expectedUrl = "https://oss.sonatype.org/service/local/artifact/maven/redirect?r=snapshots&g=io.brooklyn&v="+version+"&a=brooklyn-dist&c=dist&e=tar.gz";
    +        String version = "0.7.0-SNAPSHOT"; // BROOKLYN_VERSION
    --- End diff --
    
    Again, this is the wrong URL for `org.apache.brooklyn` snapshot artifacts (I'm guessing).
    
    There is also a chicken-and-egg problem. When we next bump the version number to 0.8.0-SNAPSHOT,
then this artifact will not be in apache nexus (or sonatype) so the test will fail. The version
would (by default) not be pushed until all tests pass. So it would require manual intervention
to fix. Should we just live with that? If so, we should note it in the release process docs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message