brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Change references to org.apache.b...
Date Mon, 13 Oct 2014 16:11:09 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/237#discussion_r18778253
  
    --- Diff: software/base/src/main/java/brooklyn/entity/brooklynnode/BrooklynNode.java ---
    @@ -73,7 +73,7 @@
         BasicAttributeSensorAndConfigKey<String> DOWNLOAD_URL = new StringAttributeSensorAndConfigKey(
                 SoftwareProcess.DOWNLOAD_URL,
                 "<#if version?contains(\"SNAPSHOT\")>"+
    -                "https://oss.sonatype.org/service/local/artifact/maven/redirect?r=snapshots&g=io.brooklyn&v=${version}&a=brooklyn-dist&c=dist&e=tar.gz"
+
    +                "https://oss.sonatype.org/service/local/artifact/maven/redirect?r=snapshots&g=org.apache.brooklyn&v=${version}&a=brooklyn-dist&c=dist&e=tar.gz"
+
    --- End diff --
    
    I don't think we'll be pushing `org.apache.brooklyn` to sonatype - I presume we'll push
it to the apache nexus. @richardcloudsoft any thoughts on that, and what will the URL look
of artifacts look like?
    
    Also, if we wanted to support installing older versions then we'd need a conditional on
the URL.
    But I'm fine with it only supporting the more recent 0.7.0 and higher.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message