brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Some further tidies in wake of la...
Date Sat, 11 Oct 2014 20:06:28 GMT
Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/233#discussion_r18744035
  
    --- Diff: core/src/main/java/brooklyn/location/basic/BasicLocationRegistry.java ---
    @@ -263,13 +273,18 @@ public Location resolve(String spec, Map locationFlags) {
                             + "either this location is not recognised or there is a problem
with location resolver configuration.";
                 }
     
    -            throw new NoSuchElementException(errmsg);
    +            return Maybe.absent(Suppliers.ofInstance(new NoSuchElementException(errmsg)));
    --- End diff --
    
    Same as above, except use `Maybe#absent(Throwable)` with the `NoSuchElementException`
instance?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message