brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Some further tidies in wake of la...
Date Thu, 09 Oct 2014 07:47:46 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/233#discussion_r18630907
  
    --- Diff: api/src/main/java/brooklyn/location/LocationRegistry.java ---
    @@ -49,35 +51,54 @@
         /** removes the defined location from the registry (applications running there are
unaffected) */
         public void removeDefinedLocation(String id);
     
    -    /** returns fully populated (config etc) location from the given definition, 
    -     * currently by creating it but TODO creation can be a leak so all current 'resolve'
methods should be carefully used! */
    +    /** Returns a fully populated (config etc) location from the given definition, with
optional add'l flags.
    +     * the location will be managed by default, unless the manage parameter is false
or the CREATE_UNMANAGED flag is set.
    +     * @since 0.7.0, but beta and likely to change as the semantics of this class are
tuned */
    +    @Beta
    +    public Maybe<Location> resolve(LocationDefinition ld, Boolean manage, Map locationFlags);
    --- End diff --
    
    What's the point of using Boolean (vs boolean)?
    Better use boolean and set CREATE_UNMANAGED only on true.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message