brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix Windows EOL issues
Date Wed, 08 Oct 2014 06:45:37 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/222#discussion_r18566215
  
    --- Diff: usage/archetypes/quickstart/src/brooklyn-sample/src/main/assembly/scripts/start.sh
---
    @@ -18,6 +18,10 @@
     # under the License.
     #
     
    +# Handle Windows line breaks on UNIX. You can replace the variables directly with the
values from project.conf
    +JAVA_PACKAGE=`awk -F '=' '/JAVA_PACKAGE/ {print $2}' conf/project.conf | tr -d '\r\n'`
    --- End diff --
    
    I agree it's not elegant but at least works.
    
    The possible solutions are:
      * Copy the shell script as is (treat as binary) and resolve needed options at runtime
(current approach)
      * Let the archetype plugin replace the variables and strip lines at build time
      * Copy the shell script as is (treat as binary) and replace variables at build time.
    
    I think the last item will result in more clean solution, I can try and see what happens.
It wasn't obvious when choosing the runtime approach that the variable extraction would be
so complex. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message