brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From richardcloudsoft <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Various: 20141007
Date Tue, 07 Oct 2014 15:21:24 GMT
Github user richardcloudsoft commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/224#issuecomment-58201930
  
    I'm confused over the "simulation" changes. `SimulatedJBoss7Server` et al are classes
that I wasn't previously aware of and which don't seem to be documented as to what or how
they do their simulation. This change modifies the simulated entities to add configuration
to enable or disable simulation. Presumably this is a *different* kind of simulation to what
the entity was previously simulating, because otherwise surely the "simulate" config key could
only ever be true :persevere:
    
    Could you drop some Javadoc into these files to explain in more detail what they do, and
in particular what the effect of changing the "simulate" config key is?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message