brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: add support for configuring couch...
Date Tue, 07 Oct 2014 11:29:40 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/221#discussion_r18512766
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/couchbase/CouchbaseNode.java
---
    @@ -49,11 +50,15 @@
     
         @SetFromFlag("version")
         ConfigKey<String> SUGGESTED_VERSION = ConfigKeys.newConfigKeyWithDefault(SoftwareProcess.SUGGESTED_VERSION,
    -            "2.5.1");
    +            "3.0.0");
    +
    +    @SetFromFlag("enterprise")
    +    ConfigKey<Boolean> USE_ENTERPRISE = ConfigKeys.newBooleanConfigKey("couchbase.enterprise.enabled",
    +        "Whether to use Couchbase Enterprise; if false uses the community version. Defaults
to true.", true);
     
         @SetFromFlag("downloadUrl")
         BasicAttributeSensorAndConfigKey<String> DOWNLOAD_URL = new BasicAttributeSensorAndConfigKey<String>(
    -            SoftwareProcess.DOWNLOAD_URL, "http://packages.couchbase.com/releases/${version}/couchbase-server-enterprise_${version}_${driver.osTag}");
    +            SoftwareProcess.DOWNLOAD_URL, "http://packages.couchbase.com/releases/${version}/couchbase-server-${driver.communityOrEnterprise}_${version}${driver.osTagWithPrefix}");
    --- End diff --
    
    ouch you're right -- the character *before* the version is `-` for `3.0.0-centos`, and
`_` for everything else (other `3.0.0` OS's, and all OS's in 2.x).  whereas the character
*after* the version is always `-`.  i had the check in the wrong place.
    
    i suggest another driver method for that character rather than complex freemarker.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message