brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: add support for configuring couch...
Date Tue, 07 Oct 2014 11:24:08 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/221#discussion_r18512563
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/couchbase/CouchbaseNodeSshDriver.java
---
    @@ -117,9 +127,16 @@ public void install() {
                     sudo("[ -f /etc/redhat-release ] && (grep -i \"red hat\" /etc/redhat-release
&& sudo yum install -y openssl098e) || :"),
                     sudo(format("rpm --install %s", saveAs)));
     
    +        String link = new DownloadProducerFromUrlAttribute().apply(new BasicDownloadRequirement(this)).getPrimaryLocations().iterator().next();
             return ImmutableList.<String>builder()
                     .add(INSTALL_CURL)
    -                .addAll(BashCommands.commandsToDownloadUrlsAs(urls, saveAs))
    +                .addAll(Arrays.asList(INSTALL_CURL, 
    +                    BashCommands.require(BashCommands.alternatives(BashCommands.simpleDownloadUrlAs(urls,
saveAs),
    +                        // Referer link is required for 3.0.0; note mis-spelling is correct,
as per http://en.wikipedia.org/wiki/HTTP_referer
    +                        "curl -f -L -k "+link
    --- End diff --
    
    hmm yes, good idea


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message