brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: add support for configuring couch...
Date Tue, 07 Oct 2014 09:29:31 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/221#discussion_r18508617
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/couchbase/CouchbaseNodeSshDriver.java
---
    @@ -179,18 +198,52 @@ public String getVersion() {
     
         @Override
         public String getOsTag() {
    -        OsDetails os = getLocation().getOsDetails();
    +        return getOsTag(getLocation().getOsDetails(), !isPreV300());
    +    }
    +    
    +    public static String getOsTag(OsDetails os, boolean isV30OrLater) {
             if (os == null) {
    -            // Default to generic linux
    -            return "x86_64.rpm";
    +            // Default to 64-bit centos linux
    +            if (isV30OrLater)
    +                return "centos6.x86_64.rpm";
    +            else
    +                return "x86_64.rpm";
    +            
             } else {
    -            //FIXME should be a better way to check for OS name and version
    +            // are there should ways to check for OS name and version
    --- End diff --
    
    typo in comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message