brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: add support for configuring couch...
Date Tue, 07 Oct 2014 08:49:50 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/221#discussion_r18507148
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/couchbase/CouchbaseCluster.java
---
    @@ -115,4 +124,10 @@
         @SetFromFlag("createBuckets")
         ConfigKey<List<Map<String, Object>>> CREATE_BUCKETS = ConfigKeys.newConfigKey(new
TypeToken<List<Map<String, Object>>>() {}, 
                 "couchbase.cluster.createBuckets", "a list of all dedicated port buckets
to be created on the couchbase cluster");
    +    
    +    @SuppressWarnings("serial")
    +    @SetFromFlag("replication")
    +    ConfigKey<List<Map<String,Object>>> REPLICATION = ConfigKeys.newConfigKey(new
TypeToken<List<Map<String,Object>>>() {}, 
    +        "couchbase.cluster.replicationConfiguration", "List of replication rules to configure,
each rule including target (id of another cluster) and mode (unidirectional or bidirectional)");
    --- End diff --
    
    Inconsistent indent - convention is 8 spaces (though line 79 also fails that). And I'd
prefer splitting into multiple lines (i.e. description on its own line) because it's so long.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message