brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Rebind read only
Date Wed, 01 Oct 2014 15:52:20 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/197#discussion_r18287645
  
    --- Diff: core/src/main/java/brooklyn/management/ha/HighAvailabilityManagerImpl.java ---
    @@ -569,6 +712,25 @@ protected void onDemotion() {
                 LOG.info("Cancelled "+tasks+" tasks on demotion");
         }
     
    +    /** starts hot standby, in foreground; the caller is responsible for publishing health
afterwards.
    +     * @return whether hot standby was possible (if not, errors should be stored elsewhere)
*/
    +    protected boolean attemptHotStandby() {
    +        try {
    +            Preconditions.checkState(nodeStateTransitionComplete==false, "Must be in
transitioning state to go into hot standby");
    +            nodeState = ManagementNodeState.HOT_STANDBY;
    +            
    +            // XXX
    --- End diff --
    
    XXX?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message