brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Rebind read only
Date Wed, 01 Oct 2014 14:13:43 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/197#discussion_r18280653
  
    --- Diff: api/src/main/java/brooklyn/entity/Entity.java ---
    @@ -127,7 +127,8 @@
         
         /** 
          * Creates an {@link Entity} from the given spec and adds it, setting this entity
as the parent,
    -     * returning the added child. */
    +     * returning the added child. The added child is not yet managed, even if the parent
is managed,
    +     * so if adding post-management an explicit call to manage the child will be needed.
*/
    --- End diff --
    
    May as well reference `Entities.manage`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message