Return-Path: X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E910911E3F for ; Fri, 19 Sep 2014 15:25:55 +0000 (UTC) Received: (qmail 22256 invoked by uid 500); 19 Sep 2014 15:25:55 -0000 Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org Received: (qmail 22225 invoked by uid 500); 19 Sep 2014 15:25:55 -0000 Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.incubator.apache.org Delivered-To: mailing list dev@brooklyn.incubator.apache.org Received: (qmail 22214 invoked by uid 99); 19 Sep 2014 15:25:55 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Sep 2014 15:25:55 +0000 X-ASF-Spam-Status: No, hits=-2000.7 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 19 Sep 2014 15:25:54 +0000 Received: (qmail 20945 invoked by uid 99); 19 Sep 2014 15:25:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Sep 2014 15:25:34 +0000 Date: Fri, 19 Sep 2014 15:25:34 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@brooklyn.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BROOKLYN-49) Catalogue should be persisted and used when rebinding MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/BROOKLYN-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140734#comment-14140734 ] ASF GitHub Bot commented on BROOKLYN-49: ---------------------------------------- Github user aledsage commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/175#discussion_r17790912 --- Diff: core/src/main/java/brooklyn/catalog/internal/CatalogItems.java --- @@ -24,45 +24,50 @@ class CatalogItems { --- End diff -- Nothing uses this except `CatalogDtoTest`. Suggest we move it into the `src/test/java`. Safe to do that because it's "Deliberately package-private. Only for internal use." Could do that in a separate PR. > Catalogue should be persisted and used when rebinding > ----------------------------------------------------- > > Key: BROOKLYN-49 > URL: https://issues.apache.org/jira/browse/BROOKLYN-49 > Project: Brooklyn > Issue Type: Improvement > Reporter: Sam Corbett > Assignee: Sam Corbett > > Proposal: > The catalogue, consisting of application templates, entities, policies and 'configuration' (whose purpose is unknown to me and is unused in general), will be persisted to a `catalog` directory alongside enrichers, entities, locations, nodes, plane and policies. Location definitions (that are conceptually linked but are unrelated in code) will be stored too. > Modes of operation: > * If persistence if disabled load the default catalogue; > * If persistence is enabled but there is no persisted catalogue (i.e. the server is running for the first time) then load the default catalogue; > * Otherwise load the persisted catalogue. Do _not_ load the default catalogue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)