Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-108-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-108-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Persist feeds
Content-Type: text/plain
Message-Id: <20140925215929.BCD058809BE@tyr.zones.apache.org>
Date: Thu, 25 Sep 2014 21:59:29 +0000 (UTC)

Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/108#issuecomment-56890567
  
    @aledsage i'll either do a new PR or a merge if it looks safe.  based on #177 it looks like i can merge master into a PR branch then merge into master and the history comes out okay.  am trying the two-step merge here (where i merged with flaws, so that my fixes are clearly in a new commit).
    
    there are a lot of places where it needs adding -- but if it works better than it did previously and doesn't break i'll do merge and ask you to review afterwards if anything is left out, unless you think i shouldn't.
    
    one question in PR #177 about logging would be handy to have your take on -- if rebind fails will we still get decent output? -- apart from that i'm getting through it, things looking reasonable so far (just tedious!)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---