brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-49) Catalogue should be persisted and used when rebinding
Date Fri, 19 Sep 2014 14:16:33 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140627#comment-14140627
] 

ASF GitHub Bot commented on BROOKLYN-49:
----------------------------------------

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/175#discussion_r17786697
  
    --- Diff: api/src/main/java/brooklyn/catalog/CatalogItem.java ---
    @@ -19,17 +19,20 @@
     package brooklyn.catalog;
     
     import java.util.List;
    -
     import javax.annotation.Nonnull;
     import javax.annotation.Nullable;
     
    +import com.google.common.annotations.Beta;
    +
    +import brooklyn.basic.BrooklynObject;
    +import brooklyn.entity.rebind.RebindSupport;
    +import brooklyn.entity.rebind.Rebindable;
     import brooklyn.management.ManagementContext;
     import brooklyn.management.classloading.BrooklynClassLoadingContext;
    -
    -import com.google.common.annotations.Beta;
    +import brooklyn.mementos.CatalogItemMemento;
     
     @Beta
    -public interface CatalogItem<T,SpecT> {
    +public interface CatalogItem<T,SpecT> extends BrooklynObject, Rebindable {
         
         public static enum CatalogItemType {
             TEMPLATE, ENTITY, POLICY, CONFIGURATION
    --- End diff --
    
    `CONFIGURATION` also looks wrong. It is only used in `CatalogResource.create(yaml)` where
it treats `CONFIGURATION` by calling `catalogEntitySummary` + `EntitySpec`. The `CatalogConfigurationDto`
is unused.


> Catalogue should be persisted and used when rebinding
> -----------------------------------------------------
>
>                 Key: BROOKLYN-49
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-49
>             Project: Brooklyn
>          Issue Type: Improvement
>            Reporter: Sam Corbett
>            Assignee: Sam Corbett
>
> Proposal:
> The catalogue, consisting of application templates, entities, policies and 'configuration'
(whose purpose is unknown to me and is unused in general), will be persisted to a `catalog`
directory alongside enrichers, entities, locations, nodes, plane and policies. Location definitions
(that are conceptually linked but are unrelated in code) will be stored too.
> Modes of operation:
> * If persistence if disabled load the default catalogue;
> * If persistence is enabled but there is no persisted catalogue (i.e. the server is running
for the first time) then load the default catalogue;
> * Otherwise load the persisted catalogue. Do _not_ load the default catalogue. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message