brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Heneveld (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-29) Verify no binaries in source release
Date Fri, 19 Sep 2014 11:02:34 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140315#comment-14140315
] 

Alex Heneveld commented on BROOKLYN-29:
---------------------------------------

I believe I have resolved this in the last two commits of https://github.com/apache/incubator-brooklyn/pull/179
.

The resolutions are as follows:

./core/src/test/resources/hello-world.war - accompanying text file added; sources included
in WAR (written by us) and the WAR is an artifact used only for testing (not included in the
distributables)

./software/webapp/src/test/resources/hello-world.war - removed, inherits from core tests
./usage/launcher/src/test/resources/hello-world.war - removed, inherits from core tests
./usage/qa/src/main/resources/hello-world.war - removed, inherits from core tests, refactored
so this is sufficient

./software/webapp/src/test/resources/seam-booking-as6.war
./software/webapp/src/test/resources/seam-booking-as7.war
./software/webapp/src/test/resources/swf-booking-mvc.war
  - all three above removed (either not used or replaced by hello-world.war)

./sandbox/examples/src/main/resources/hello-world.war
./sandbox/examples/src/main/resources/swf-booking-mvc.war
  - entire sandbox/examples removed (very very old!)

./software/nosql/src/test/resources/solr/example.tgz - accompanying text file added; the tarball
is purely source files used for example (not included in the distributables)

./examples/simple-nosql-cluster/src/main/resources/cumulusrdf.war - removed, replaced with
reference to hosted version at https://cumulusrdf.googlecode.com/svn/wiki/downloads/cumulusrdf-1.0.1.war

[~Nakomis] this does not build on your change as it makes the build much more complex (examples
required to be built before you can run integration tests).  if it is required then i suggest
we move hello-world out to a separate project where it can be hosted.  (in fact this might
be a good idea for our example webapps in any case).

> Verify no binaries in source release
> ------------------------------------
>
>                 Key: BROOKLYN-29
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-29
>             Project: Brooklyn
>          Issue Type: Sub-task
>            Reporter: Richard Downer
>            Assignee: Martin Harris
>             Fix For: 0.7.0-M2
>
>
> The source code contains a "hello world" WAR file used for some integration tests. Other
projects have hit a speed bump with their source releases containing binaries, so we will
likely hit the same problems. Search the source tree for all cases where we may be including
binary files. Determine how other projects have addressed these problems and apply similar
fixes to Brooklyn.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message