brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: [WIP] Rebind read only
Date Tue, 30 Sep 2014 08:28:26 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/197#discussion_r18204508
  
    --- Diff: core/src/main/java/brooklyn/entity/proxying/EntityProxyImpl.java ---
    @@ -53,6 +57,7 @@
         private static final Logger LOG = LoggerFactory.getLogger(EntityProxyImpl.class);
     
         private final Entity delegate;
    --- End diff --
    
    Longer-term (e.g. if writing something that we think should be the structure for a federated
brooklyn, with different entities managed at different nodes), then I'm not comfortable wit
the `EntityProxyImpl` being given a pointer to a `final Entity`. It should be to a "forwarding-entity"
of some description, that can then be switched out for the real entity.
    
    But for the short term (i.e. when only use-case is read-only mirror), I think I'm hesitantly
ok with this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message