brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alasdairhodge <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Added install resources configura...
Date Mon, 29 Sep 2014 15:23:14 GMT
Github user alasdairhodge commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/165#discussion_r18161219
  
    --- Diff: software/base/src/main/java/brooklyn/entity/basic/AbstractSoftwareProcessDriver.java
---
    @@ -150,10 +155,11 @@ public void preInstall() {}
     
         public abstract void runPreInstallCommand(String command);
         public abstract void setup();
    +    public abstract void installResources();
         public abstract void install();
         public abstract void runPostInstallCommand(String command);
    +    public abstract void runtimeResources();
         public abstract void customize();
    -    public abstract void resources();
    --- End diff --
    
    Also, I'm not mad keen on the verb-less names of the resource-related methods, but that's
a niggle.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message