brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alasdairhodge <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Added install resources configura...
Date Mon, 29 Sep 2014 15:17:09 GMT
Github user alasdairhodge commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/165#discussion_r18160723
  
    --- Diff: core/src/main/java/brooklyn/entity/basic/BrooklynConfigKeys.java ---
    @@ -106,16 +106,18 @@
         /** @deprecated since 0.7.0; use {@link #RUN_DIR} */
         public static final ConfigKey<String> SUGGESTED_RUN_DIR = RUN_DIR.getConfigKey();
     
    -    /**
    -     * Intention is to use this with DependentConfiguration.attributeWhenReady, to allow
an entity's start
    +    /*
    +     * Intention is to use these with DependentConfiguration.attributeWhenReady, to allow
an entity's start
          * to block until dependents are ready. This is particularly useful when we want
to block until a dependent
          * component is up, but this entity does not care about the dependent component's
actual config values.
          */
    +
         public static final ConfigKey<Boolean> START_LATCH = newBooleanConfigKey("start.latch",
"Latch for blocking start until ready");
         public static final ConfigKey<Boolean> SETUP_LATCH = newBooleanConfigKey("setup.latch",
"Latch for blocking setup until ready");
    +    public static final ConfigKey<Boolean> INSTALL_RESOURCES_LATCH = newBooleanConfigKey("resources.install.latch",
"Latch for blocking install resources until ready");
         public static final ConfigKey<Boolean> INSTALL_LATCH = newBooleanConfigKey("install.latch",
"Latch for blocking install until ready");
    +    public static final ConfigKey<Boolean> RUNTIME_RESOURCES_LATCH = newBooleanConfigKey("resources.runtime.latch",
"Latch for blocking runtime resources until ready");
         public static final ConfigKey<Boolean> CUSTOMIZE_LATCH = newBooleanConfigKey("customize.latch",
"Latch for blocking customize until ready");
    -    public static final ConfigKey<Boolean> RESOURCES_LATCH = newBooleanConfigKey("resources.latch",
"Latch for blocking resources until ready");
    --- End diff --
    
    There's no `@Beta` annotation on the class; suggest a deprecation cycle before deletion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message