brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Add type coercion for parameteriz...
Date Tue, 23 Sep 2014 17:54:55 GMT
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/182#issuecomment-56561611
  
    I know I said I wasn't sure about this but I've changed my mind.
    
    I don't want to go too far down this slippery slope but this seems pretty safe and very
useful.  And certainly there are some important fixes here (coercing to `Set` where `List`
was wanted!).  So merging.
    
    One thought, perhaps the returned coerced collection/map objects should be `MutableList.asUnmodifiable`
(since they are now likely to be copies we do not want the user to modify them in error!)
?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message