brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Credentials parameters in URLs - ...
Date Tue, 23 Sep 2014 14:32:45 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/185#discussion_r17911954
  
    --- Diff: core/src/main/java/brooklyn/util/ResourceUtils.java ---
    @@ -62,6 +72,7 @@
         
         private static final Logger log = LoggerFactory.getLogger(ResourceUtils.class);
         private static final List<Function<Object,BrooklynClassLoadingContext>>
classLoaderProviders = Lists.newCopyOnWriteArrayList();
    +    private static final Pattern AUTH_URL = Pattern.compile("http(?:s?)://([^:]+):([^@]+)@.*");
    --- End diff --
    
    > what does (?:s?) do?
    Optional 's'
    (?: is non-capturing group with s? inside.
    
    Re-worked the code so it doesn't use the regex at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message