brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <>
Subject [GitHub] incubator-brooklyn pull request: Credentials parameters in URLs - ...
Date Tue, 23 Sep 2014 12:49:31 GMT
Github user ahgittin commented on a diff in the pull request:
    --- Diff: core/src/main/java/brooklyn/util/ ---
    @@ -62,6 +72,7 @@
         private static final Logger log = LoggerFactory.getLogger(ResourceUtils.class);
         private static final List<Function<Object,BrooklynClassLoadingContext>>
classLoaderProviders = Lists.newCopyOnWriteArrayList();
    +    private static final Pattern AUTH_URL = Pattern.compile("http(?:s?)://([^:]+):([^@]+)@.*");
    --- End diff --
    what does `(?:s?)` do?
    do we need to exclude `/` before the `@`?
    my first guess (untested) would be something like `http(s?)://([^/:]+):([^/@]+)@.*`

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message